Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix constants usage in fs.access example #39289

Closed
wants to merge 1 commit into from
Closed

doc: fix constants usage in fs.access example #39289

wants to merge 1 commit into from

Conversation

cbourgois
Copy link
Contributor

Fix fs.constants usage in fs.access doc example

@github-actions github-actions bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 6, 2021
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Landed in 4de6f20...9b68d84

@github-actions github-actions bot closed this Jul 7, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 7, 2021
@cbourgois @nodejs-github-bot
doc: fix constants usage in fs.access example
9b68d84 
PR-URL: #39289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2021
@cbourgois @targos
doc: fix constants usage in fs.access example
146f733 
PR-URL: #39289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@cbourgois @targos
doc: fix constants usage in fs.access example
2ef61b9 
PR-URL: #39289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

@dgonzalez dgonzalez dgonzalez approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbourgois @dgonzalez @lpinca @aduh95