-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix comment regarding child_process file #39308
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cluster
Issues and PRs related to the cluster subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2021
VoltrexKeyva
reviewed
Jul 8, 2021
Fixed comment for the description of INTERNAL_PREFIX in child_process whereas the value is present in the internal/child_process.js.
yashLadha
force-pushed
the
fix_cluster_comments
branch
from
July 8, 2021 23:35
5113405
to
a72f234
Compare
cjihrig
approved these changes
Jul 9, 2021
jasnell
approved these changes
Jul 9, 2021
gireeshpunathil
approved these changes
Aug 16, 2021
gireeshpunathil
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Aug 16, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2021
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Aug 22, 2021
Landed in 2acd866 |
jasnell
pushed a commit
that referenced
this pull request
Aug 25, 2021
Fixed comment for the description of INTERNAL_PREFIX in child_process whereas the value is present in the internal/child_process.js. PR-URL: #39308 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Fixed comment for the description of INTERNAL_PREFIX in child_process whereas the value is present in the internal/child_process.js. PR-URL: #39308 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
cluster
Issues and PRs related to the cluster subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed comment for the description of INTERNAL_PREFIX in child_process
whereas the value is present in the internal/child_process.js.