crypto: fix generateKeyPair with encoding 'jwk'

[himself65]

Fixes: #39205

[Trott]

@nodejs/crypto

[panva]

@himself65

The PR's on a good track, but lacks some of the details that are present in KeyObject.prototype.export

more concretely

• https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L240-L247
• https://github.com/nodejs/node/blob/v16.4.2/lib/internal/crypto/keys.js#L193-L213

I think there are a few ways of moving forward

• either moving these asserts to C and have export just call the appropriate C method
• having generate piggyback on a keyobject and then returning the results of calling export on those
• a combination of those, e.g. leave the passphrase part in JS but move the rest to C

[himself65]

kAsymmetricKeyJWKProperties is not a static method, so we have to call it after initialized.'

I'd like to move these to the C part. because the second way must have performance regression. And the third way looks like a too complex struct.

[himself65]

I've moved kAsymmetricKeyJWKProperties to the c++ part. is it correct?

[himself65]

node/src/crypto/crypto_ec.cc

Lines 790 to 812 in 95bd164

	const char* curve = nullptr;
	switch (EVP_PKEY_id(pkey.get())) {
	case EVP_PKEY_ED25519:
	curve = "Ed25519";
	break;
	case EVP_PKEY_ED448:
	curve = "Ed448";
	break;
	case EVP_PKEY_X25519:
	curve = "X25519";
	break;
	case EVP_PKEY_X448:
	curve = "X448";
	break;
	default:
	UNREACHABLE();
	}
	if (target->Set(
	env->context(),
	env->jwk_crv_string(),
	OneByteString(env->isolate(), curve)).IsNothing()) {
	return Nothing<bool>();
	}

addressed

[himself65]

/cc @nodejs/crypto

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39170/

[himself65]

Does anyone review this pr? I think this is a nice fix 🤔

[panva]

cc @nodejs/crypto

[jasnell]

Landed in 257312a