-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: allow an event to be dispatched multiple times #39395
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Jul 15, 2021
Use a different flag to prevent recursive dispatching.
lpinca
changed the title
events: reset the event target to null
events: allow an event to be dispatched multiple times
Jul 21, 2021
@aduh95 PTAL. |
aduh95
approved these changes
Jul 21, 2021
@@ -151,12 +153,12 @@ class Event { | |||
// These are not supported in Node.js and are provided purely for | |||
// API completeness. | |||
|
|||
composedPath() { return this[kTarget] ? [this[kTarget]] : []; } | |||
composedPath() { return this[kIsBeingDispatched] ? [this[kTarget]] : []; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR: Chromium and Safari both return an empty array when dispatching an event. Firefox has the same behavior as Node.js. I couldn't find which behavior is spec compliant.
{
// Same event dispatched multiple times.
const event = new Event('foo');
const eventTarget1 = new EventTarget();
const eventTarget2 = new EventTarget();
eventTarget1.addEventListener('foo', ((event) => {
console.log(event.target===eventTarget1, event.eventPhase===Event.AT_TARGET); // true true
const path = event.composedPath();
console.log(path.length === 1, path[0]===eventTarget1); // depends on the browser:
// On Firefox + Node.js: true true
// On Safari + Chromium : false false
}));
eventTarget2.addEventListener('foo', ((event) => {
console.log(event.target===eventTarget2, event.eventPhase===Event.AT_TARGET); // true true
const path = event.composedPath();
console.log(path.length === 1, path[0]===eventTarget2); // depends on the browser
}));
eventTarget1.dispatchEvent(event);
console.log(event.target===eventTarget1, event.eventPhase===Event.NONE); // true true
console.log(event.composedPath().length === 0); // true
eventTarget2.dispatchEvent(event);
console.log(event.target===eventTarget2, event.eventPhase===Event.NONE); // true true
console.log(event.composedPath().length === 0); // true
}
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 21, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 21, 2021
jasnell
approved these changes
Jul 21, 2021
lpinca
added
the
eventtarget
Issues and PRs related to the EventTarget implementation.
label
Jul 25, 2021
lpinca
added a commit
that referenced
this pull request
Jul 25, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 5c4e673. |
targos
pushed a commit
that referenced
this pull request
Jul 26, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
Use a different flag to prevent recursive dispatching. PR-URL: #39395 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mrbbot
added a commit
to mrbbot/node
that referenced
this pull request
Aug 15, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. Refs: nodejs#39395
mrbbot
added a commit
to mrbbot/node
that referenced
this pull request
Aug 15, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. Refs: nodejs#39395
lpinca
pushed a commit
that referenced
this pull request
Sep 26, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. PR-URL: #39772 Refs: #39395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Fast path for EventTarget dispatch with no listeners didn't reset kIsBeingDispatched flag, meaning same event couldn't be dispatched multiple times. PR-URL: #39772 Refs: #39395 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
eventtarget
Issues and PRs related to the EventTarget implementation.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different flag to prevent recursive dispatching.