-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add NumberFormat resolvedOptions test #39401
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a regression test for NumberFormat resolvedOptions.
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Jul 15, 2021
targos
approved these changes
Jul 15, 2021
richardlau
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Jul 15, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 15, 2021
cjihrig
approved these changes
Jul 16, 2021
tniessen
approved these changes
Jul 16, 2021
Fast-track has been requested by @targos. Please 👍 to approve. |
Small test addition, blocking a backport... fast-track? |
Landed in 07e83f7 |
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 18, 2021
Add a regression test for NumberFormat resolvedOptions. PR-URL: nodejs#39401 Refs: nodejs#39050 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau
added a commit
to targos/node
that referenced
this pull request
Jul 19, 2021
Add a regression test for NumberFormat resolvedOptions. PR-URL: nodejs#39401 Refs: nodejs#39050 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 20, 2021
Add a regression test for NumberFormat resolvedOptions. PR-URL: nodejs#39401 Refs: nodejs#39050 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Add a regression test for NumberFormat resolvedOptions. PR-URL: nodejs#39401 Refs: nodejs#39050 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Backport-PR-URL: nodejs#39051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a regression test for NumberFormat resolvedOptions.
Refs: #39050
I'd like to land this on v14.x-staging together with/as part of #39051. We now have a CI job that builds Node.js dynamically linked against the minimum supported level of ICU but the job isn't failing on
v14.x-staging
for the problem reported in #39050 as we don't have the coverage.