-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update ESLint to 7.31.0 #39424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Jul 18, 2021
tniessen
approved these changes
Jul 18, 2021
jasnell
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
cjihrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 20, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 20, 2021
Commit Queue failed- Loading data for nodejs/node/pull/39424 ✔ Done loading data for nodejs/node/pull/39424 ----------------------------------- PR info ------------------------------------ Title tools: update ESLint to 7.31.0 (#39424) Author Colin Ihrig (@cjihrig) Branch cjihrig:eslint -> nodejs:master Labels tools Commits 1 - tools: update ESLint to 7.31.0 Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/39424 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39424 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 18 Jul 2021 03:22:59 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39424#pullrequestreview-708989010 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709032777 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709614517 ✖ Last GitHub CI failed ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1048898869 |
github-actions
bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Jul 20, 2021
cjihrig
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Jul 24, 2021
cjihrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 27, 2021
github-actions
bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jul 27, 2021
Commit Queue failed- Loading data for nodejs/node/pull/39424 ✔ Done loading data for nodejs/node/pull/39424 ----------------------------------- PR info ------------------------------------ Title tools: update ESLint to 7.31.0 (#39424) Author Colin Ihrig (@cjihrig) Branch cjihrig:eslint -> nodejs:master Labels tools Commits 1 - tools: update ESLint to 7.31.0 Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/39424 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39424 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 18 Jul 2021 03:22:59 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39424#pullrequestreview-708989010 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709032777 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709614517 ✖ Last GitHub CI failed ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1068048418 |
Update ESLint to 7.31.0 PR-URL: nodejs#39424 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Update ESLint to 7.31.0 PR-URL: #39424 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Update ESLint to 7.31.0 PR-URL: #39424 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.31.0