Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.31.0 #39424

Merged
merged 1 commit into from
Jul 28, 2021
Merged

tools: update ESLint to 7.31.0 #39424

merged 1 commit into from
Jul 28, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 18, 2021

Update ESLint to 7.31.0

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 18, 2021
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39424
✔  Done loading data for nodejs/node/pull/39424
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.31.0 (#39424)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    1
 - tools: update ESLint to 7.31.0
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/39424
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39424
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 18 Jul 2021 03:22:59 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39424#pullrequestreview-708989010
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709032777
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709614517
   ✖  Last GitHub CI failed
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1048898869

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 20, 2021
@cjihrig cjihrig removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 24, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2021

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39424
✔  Done loading data for nodejs/node/pull/39424
----------------------------------- PR info ------------------------------------
Title      tools: update ESLint to 7.31.0 (#39424)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:eslint -> nodejs:master
Labels     tools
Commits    1
 - tools: update ESLint to 7.31.0
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/39424
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39424
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 18 Jul 2021 03:22:59 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39424#pullrequestreview-708989010
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709032777
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39424#pullrequestreview-709614517
   ✖  Last GitHub CI failed
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1068048418

Update ESLint to 7.31.0

PR-URL: nodejs#39424
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 31e8c63 into nodejs:master Jul 28, 2021
@cjihrig cjihrig deleted the eslint branch July 28, 2021 04:27
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Update ESLint to 7.31.0

PR-URL: #39424
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Update ESLint to 7.31.0

PR-URL: #39424
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants