Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: handle pending exception in callback wrapper #39476

Closed
wants to merge 2 commits into from
Closed

node-api: handle pending exception in callback wrapper #39476

wants to merge 2 commits into from

Commits on Jul 21, 2021

  1. node-api: handle pending exception in cb wrapper 

    fixes: nodejs/node-addon-api#1025

The functionreference test from the node-api tests
was reporting a failed v8 check when Node.js was compiled
as debug. The failure was because an exception was
pending but the C++ wrappers were returning
a return value that was invalid.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    77018ed View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. squash: add test 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    @mhdawson
    mhdawson committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    569c542 View commit details
    Browse the repository at this point in the history