Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.22.4 proposal #39500

Merged
merged 23 commits into from
Jul 29, 2021
Merged

v12.22.4 proposal #39500

merged 23 commits into from
Jul 29, 2021

Commits on Jul 23, 2021

  1. build: label PRs with GitHub Action instead of nodejs-github-bot

    Main goal of using a GitHub Action for labelling PRs has been to move
    the mapping between files changed -> label into a configuration file
    local to the nodejs/node repository.
    
    Previously any changes to that mapping meant having to grasp the
    nodejs/github-bot project, open a PR with the neccessary changes, get
    approval from its maintainers before those changes finally got pushed
    to production.
    
    The logic involved in using the file paths / label configuration and
    resolving the labels to be applied, has been moved into a custom GitHub
    Action project: nodejs/node-pr-labeler.
    
    Aside from removing the external dependency the nodejs-github-bot is in
    practise, it also reduces the bar for contributors since the resulting
    project is a lot smaller and less complex than nodejs/github-bot.
    
    PR-URL: #38301
    Fixes: nodejs/github-bot#294
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    phillipj authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    98ac3c4 View commit details
    Browse the repository at this point in the history
  2. build: fix label-pr workflow

    PR-URL: #38399
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    499e56b View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick 530080c44af2

    Original commit message:
    ```
    PPC: Add Power10 to the supported list and enable related features
    
    This CL adds Power10 recognition to Linux, AIX as well as IBMi.
    
    Enabled features include:
    MODULO
    FPR_GPR_MOV
    SIMD
    LWSYNC
    ISELECT
    VSX
    
    Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: Junliang Yan <junyan@redhat.com>
    Reviewed-by: Vasili Skurydzin <vasili.skurydzin@ibm.com>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#74279}
    ```
    
    Refs: v8/v8@530080c
    
    PR-URL: #38509
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    miladfarca authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    93a1a3c View commit details
    Browse the repository at this point in the history
  4. deps: V8: backport 1b1eda0876aa

    Original commit message:
    
        tracing: Update proto library build rule and roll Perfetto
    
        This patch removes use of the deprecated sources_assignment_filter GN
        feature from gni/proto_library.gni, since the extra descriptor files are
        no longer being generated.
    
        We also roll Perfetto to match the version used in Chrome and update
        test expectations accordingly.
    
        Bug: v8:10995
        Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
        Commit-Queue: Michael Achenbach <machenbach@chromium.org>
        Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Reviewed-by: Michael Achenbach <machenbach@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70381}
    
    Refs: v8/v8@1b1eda0
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    bbceab4 View commit details
    Browse the repository at this point in the history
  5. deps: V8: cherry-pick 92e6d3317082

    Original commit message:
    
        build: Remove no-op calls to set_sources_assignment_filter
    
        Chromiun no longer use set_sources_assignment_filter() anywhere in the
        build, so these are no longer needed.
    
        Bug: chromium:1018739
        Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
        Reviewed-by: Nico Weber <thakis@chromium.org>
        Commit-Queue: Nico Weber <thakis@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70405}
    
    Refs: v8/v8@92e6d33
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2b54156 View commit details
    Browse the repository at this point in the history
  6. deps: V8: cherry-pick e6f62a41f5ee

    Original commit message:
    
        [build] Remove jumbo build configs
    
        Bug: chromium:994387
        Change-Id: I7b37a416ce6cc79903fe04923e86af1d0065ac37
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890090
        Reviewed-by: Maya Lekova <mslekova@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Commit-Queue: Michael Achenbach <machenbach@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64669}
    
    Refs: v8/v8@e6f62a4
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    492b0d6 View commit details
    Browse the repository at this point in the history
  7. deps: V8: cherry-pick 7b3332844212

    Original commit message:
    
        [build] Move split_static_library.gni from Chromium repo
    
        We'll remove the file from Chromium in a follow up after V8 has rolled
        + 2 days.
    
        Bug: v8:9911
        Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826
        Reviewed-by: Nico Weber <thakis@chromium.org>
        Commit-Queue: Michael Achenbach <machenbach@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64742}
    
    Refs: v8/v8@7b33328
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a73275f View commit details
    Browse the repository at this point in the history
  8. deps: V8: cherry-pick cc641f6be756

    Original commit message:
    
        Add a simple gclient_args.gni file to V8
    
        Bug: v8:9914
        Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100
        Reviewed-by: Michael Achenbach <machenbach@chromium.org>
        Commit-Queue: Maya Lekova <mslekova@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#64680}
    
    Refs: v8/v8@cc641f6
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    add7b5b View commit details
    Browse the repository at this point in the history
  9. deps: V8: cherry-pick 7c182bd65f42

    Original commit message:
    
        Fix visiblity rules for configs enforced by the latest GN version.
    
        Prior versions of GN had a bug (gn:22) where visibility rules
        for configs weren't being enforced properly.
    
        This CL tweaks the visibility settings of some configs to
        conform to the latest version.
    
        Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
        Commit-Queue: Dirk Pranke <dpranke@google.com>
        Reviewed-by: Adam Klein <adamk@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69463}
    
    Refs: v8/v8@7c182bd
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f4377b1 View commit details
    Browse the repository at this point in the history
  10. deps: V8: cherry-pick 0b3a4ecf7083

    Original commit message:
    
        Fix implicit conversion loses integer precision warning
    
        The type of m is long in 64 bits build, and results implicit conversion
        loses integer precision, which was found by improved clang warning
        (-Wshorten-64-to-32)
    
        Bug: chromium:1124085
        Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
        Commit-Queue: Zequan Wu <zequanwu@google.com>
        Auto-Submit: Zequan Wu <zequanwu@google.com>
        Reviewed-by: Nico Weber <thakis@chromium.org>
        Reviewed-by: Igor Sheludko <ishell@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69686}
    
    Refs: v8/v8@0b3a4ec
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    8046daf View commit details
    Browse the repository at this point in the history
  11. deps: V8: backport 895949419186

    Original commit message:
    
        Add -Wno-string-concatenation to test/cctest:cctest_sources
    
        v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.
    
        Bug: chromium:1114873
        Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
        Commit-Queue: Arthur Eubanks <aeubanks@google.com>
        Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69625}
    
    Refs: v8/v8@8959494
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    15b91fa View commit details
    Browse the repository at this point in the history
  12. deps: V8: update build dependencies

    These updates are necessary to build V8 with recent GN versions.
    
    PR-URL: #39245
    Refs: nodejs/build#2696
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    906b43e View commit details
    Browse the repository at this point in the history
  13. deps: update to cjs-module-lexer@1.1.1

    PR-URL: #37992
    Backport-PR-URL: #38003
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    guybedford authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7d5a2f9 View commit details
    Browse the repository at this point in the history
  14. deps: update to cjs-module-lexer@1.2.1

    PR-URL: #38450
    Backport-PR-URL: #39422
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    guybedford authored and richardlau committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b3c698a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. src: update cares_wrap OpenBSD defines

    Move the `#define`s back into `cares_wrap.cc`, as they are part of
    the implementation, not the declarations used in `cares_wrap.h`,
    and apply the suggestion from
    #38572 (comment)
    to make the defines a bit more generic and not check for OpenBSD
    specifically.
    
    Refs: #38572
    
    PR-URL: #38670
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and richardlau committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    30ce0e6 View commit details
    Browse the repository at this point in the history
  2. src: move CHECK in AddIsolateFinishedCallback

    `CHECK(it->second)` asserts that we have `PerIsolatePlatformData`
    in the `per_isolate_` map, and not just a key with empty value. When
    `it == per_isolate_.end()`, however, it means that we don't have the
    isolate and the `CHECK(it->second)` is guaranteed to fail then!
    
    PR-URL: #38010
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    indutny authored and richardlau committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f552c45 View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick 035c305ce776

    Original commit message:
    
        [Intl] call new ListFormatter::createInstance
    
        The one we currently using is now marked as internal and to be removed
        for 68. Migrating to the style which already avaiable in ICU 67-1.
    
        Bug: v8:11031
        Change-Id: I668382a2e1b8602ddca02bf231c5008a6c92bf2d
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477751
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70638}
    
    Refs: v8/v8@035c305
    
    PR-URL: #38497
    Backport-PR-URL: #39451
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    targos authored and richardlau committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    e459c79 View commit details
    Browse the repository at this point in the history
  4. deps: restore minimum ICU version to 65

    This modifies 40df0dc so that the changes it applies are only used
    if ICU 67 or greater is used, and restores the previous code path for
    versions of ICU below 67.
    
    The minimum ICU version was bumped to 67 in Node.js 14.6.0 by
    #34356 but the referenced V8
    commit[1] isn't on `v14.x-staging` and appears to have been reverted
    on V8 8.4[2] so this PR also restores the minimum ICU version to 65.
    
    [1] v8/v8@611e412
    [2] v8/v8@eeccede
    
    PR-URL: #39068
    Backport-PR-URL: #39451
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    richardlau committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    39e9cd5 View commit details
    Browse the repository at this point in the history
  5. deps: update to c-ares 1.17.1

    PR-URL: #36207
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lxdicted authored and richardlau committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    e11a862 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. http2: on receiving rst_stream with cancel code add it to pending list

    PR-URL: #39423
    Backport-PR-URL: #39527
    Fixes: #38964
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    kumarak authored and richardlau committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b263f25 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. deps: upgrade npm to 6.14.14

    PR-URL: #39553
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    darcyclarke authored and richardlau committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    ddc8dde View commit details
    Browse the repository at this point in the history
  2. module: fix legacy node specifier resolution to resolve "main" field

    PR-URL: #38979
    Backport-PR-URL: #39497
    Fixes: #32103
    Fixes: #38739
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    aduh95 authored and richardlau committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3e4bc1b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. 2021-07-29, Version 12.22.4 'Erbium' (LTS)

    This is a security release.
    
    Notable changes:
    
    - CVE-2021-22930: Use after free on close http2 on stream canceling (High)
    
    PR-URL: #39500
    richardlau committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    2fdf989 View commit details
    Browse the repository at this point in the history