-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: align email address in README/.mailmap/AUTHORS #39503
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jul 24, 2021
MylesBorins
approved these changes
Jul 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README.
aduh95
approved these changes
Jul 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
tniessen
approved these changes
Jul 24, 2021
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 24, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 24, 2021
Landed in 6140b37...32723ae |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 24, 2021
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 25, 2021
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: #39503 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify .mailmap so Myles has the same email address in AUTHORS as he
does in README.