Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update collaborator emails in README #39521

Closed
wants to merge 3 commits into from
Closed

meta: update collaborator emails in README #39521

wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 26, 2021

Update emails to correspond to what is specified in .mailmap and what is used in recently authored commits.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 26, 2021
himself65
himself65 requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to use the old email address since maybe I will leave this company in the next month

@Trott
meta: update collaborator email in AUTHORS/.mailmap
ed1e206 
Update email for Zeyu Yang.
@Trott
meta: update collaborator email in README
4bebca8 
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.
@Trott
Copy link
Member Author

Trott commented Jul 26, 2021

i would like to use the old email address

OK, I restored that email address to README and also made it the email used in AUTHORS (by updating .mailmap). PTAL

himself65
himself65 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ryzokuken
ryzokuken approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2021
@github-actions
Copy link
Contributor

Landed in 31e8c63...b14fb01

@github-actions github-actions bot closed this Jul 28, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
@Trott @nodejs-github-bot
meta: update collaborator email in AUTHORS/.mailmap
3049026 
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
@Trott @nodejs-github-bot
meta: update collaborator email in README
069a244 
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
@Trott @nodejs-github-bot
meta: update collaborator email in AUTHORS/.mailmap
b14fb01 
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
meta: update collaborator email in AUTHORS/.mailmap
23bc4cf 
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
meta: update collaborator email in README
72af147 
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
meta: update collaborator email in AUTHORS/.mailmap
110c088 
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: update collaborator email in AUTHORS/.mailmap
5e1c49f 
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: update collaborator email in README
27e9a44 
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: update collaborator email in AUTHORS/.mailmap
fdcc572 
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
@Trott Trott deleted the last-updates branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @lpinca @ryzokuken @himself65 @nodejs-github-bot