Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.32.0 #39602

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 7.32.0 #39602

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 31, 2021 •
edited
Loading

Update ESLint to 7.32.0

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 31, 2021
cjihrig
cjihrig approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PR comment mentions the wrong version of ESLint though.

lpinca added a commit that referenced this pull request Aug 2, 2021
@lpinca
tools: update ESLint to 7.32.0
2963549 
PR-URL: #39602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented Aug 2, 2021

Landed in 2963549.

@lpinca lpinca closed this Aug 2, 2021
@lpinca lpinca deleted the update/eslint branch August 2, 2021 16:45
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@lpinca @danielleadams
tools: update ESLint to 7.32.0
d1360fc 
PR-URL: #39602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@lpinca @targos
tools: update ESLint to 7.32.0
1353a6e 
PR-URL: #39602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leko Leko Leko approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @Leko @cjihrig @nodejs-github-bot