-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use helper for readability #39649
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesteery
reviewed
Aug 3, 2021
jasnell
approved these changes
Aug 3, 2021
Used an extra `checkReusedHandle()` helper function to increase readability.
tniessen
approved these changes
Aug 3, 2021
RaisinTen
approved these changes
Aug 7, 2021
RaisinTen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Aug 7, 2021
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2021
Used an extra `checkReusedHandle()` helper function to increase readability. PR-URL: #39649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Landed in 937bbc5 |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Used an extra `checkReusedHandle()` helper function to increase readability. PR-URL: #39649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used an extra
checkReusedHandle()
helper function toincrease readability.