Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use helper for readability #39649

Closed
wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Aug 3, 2021

Used an extra checkReusedHandle() helper function to
increase readability.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 3, 2021
Used an extra `checkReusedHandle()` helper function to
increase readability.
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2021
@nodejs-github-bot
Copy link
Collaborator

jasnell pushed a commit that referenced this pull request Aug 12, 2021
Used an extra `checkReusedHandle()` helper function to
increase readability.

PR-URL: #39649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 12, 2021

Landed in 937bbc5

@jasnell jasnell closed this Aug 12, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-9 branch August 12, 2021 22:07
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Used an extra `checkReusedHandle()` helper function to
increase readability.

PR-URL: #39649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants