worker_threads: add brand checks for detached properties/methods #39763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper brand-checking for detached property and method accesses. Also adds a note about non-standard APIs and makes the standard accessors enumerable. Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Aug 14, 2021
addaleax
approved these changes
Aug 14, 2021
tniessen
approved these changes
Aug 15, 2021
jasnell
added
author ready
|
Landed in 966060d |
jasnell
added a commit
that referenced
this pull request
Aug 16, 2021
Add proper brand-checking for detached property and method accesses. Also adds a note about non-standard APIs and makes the standard accessors enumerable. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39763 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Add proper brand-checking for detached property and method accesses. Also adds a note about non-standard APIs and makes the standard accessors enumerable. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39763 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper brand-checking for detached property and method
accesses. Also adds a note about non-standard APIs and
makes the standard accessors enumerable.
Signed-off-by: James M Snell jasnell@gmail.com