-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use validateArray
#39774
Closed
Closed
lib: use validateArray
#39774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
worker
Issues and PRs related to Worker support.
labels
Aug 15, 2021
jasnell
approved these changes
Aug 15, 2021
tniessen
approved these changes
Aug 16, 2021
lpinca
approved these changes
Aug 16, 2021
The `validateArray()` validator could be used to cleanup validation and keep consistency.
VoltrexKeyva
force-pushed
the
patch-3
branch
from
September 3, 2021 15:44
60e51ad
to
c459a3b
Compare
VoltrexKeyva
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 3, 2021
Ayase-252
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 23, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 23, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 24, 2021
21 tasks
Lxxyx
approved these changes
Sep 26, 2021
XadillaX
approved these changes
Sep 26, 2021
Ayase-252
approved these changes
Sep 26, 2021
Ayase-252
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 26, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 26, 2021
Landed in b25a73f...256fe21 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2021
The `validateArray()` validator could be used to cleanup validation and keep consistency. PR-URL: #39774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This was referenced Sep 27, 2021
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
The `validateArray()` validator could be used to cleanup validation and keep consistency. PR-URL: #39774 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
worker
Issues and PRs related to Worker support.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validateArray()
validator could be used to cleanup validationand keep consistency.