Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update gyp-next to v0.9.5 #39818

Closed
wants to merge 1 commit into from
Closed

tools: update gyp-next to v0.9.5 #39818

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v12.x gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 20, 2021
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39607/

jasnell
jasnell approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 21, 2021
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2021
@github-actions
Copy link
Contributor

Landed in 0073831...28113ed

@github-actions github-actions bot closed this Aug 23, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 23, 2021
@gengjiawen @nodejs-github-bot
tools: update gyp-next to v0.9.5
28113ed 
PR-URL: #39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gengjiawen gengjiawen deleted the bump_gyp branch August 23, 2021 07:48
targos pushed a commit that referenced this pull request Aug 23, 2021
@gengjiawen @targos
tools: update gyp-next to v0.9.5
d82ee96 
PR-URL: #39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @nodejs-github-bot @jasnell @targos @cjihrig