Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime() #39834

Closed
wants to merge 1 commit into from
Closed

[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime() #39834

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

PR-URL: #39695
Backport-PR-URL: #39834
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com

@RaisinTen
[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime()
2717fe6 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: nodejs#39695
Backport-PR-URL: nodejs#39834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Aug 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39619/

@RaisinTen RaisinTen requested review from addaleax and jasnell August 21, 2021 14:52
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@targos
Copy link
Member

targos commented Aug 22, 2021

Nits about the commit message (I'll fix while landing):

  • The [v16.x backport] should only be added to the PR title, not to the commit message
  • Backport-PR-URL is added while landing (with git node land --backport)

Basically, when you backport a PR, you only need to git cherry-pick the commits and fix the conflicts, keeping the original message.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 22, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39637/

targos pushed a commit that referenced this pull request Aug 23, 2021
@RaisinTen @targos
src: return Maybe<bool> from InitializeContextRuntime()
3a8399e 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #39695
Backport-PR-URL: #39834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Aug 23, 2021

Landed in 3a8399e

@targos targos closed this Aug 23, 2021
@RaisinTen RaisinTen deleted the backport-39695-to-v16.x branch August 23, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaisinTen @nodejs-github-bot @targos