-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update maintaining openssl guide #39878
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the maintaining openssl guide to mention following the instructions in the v14.x-staging version of the guide for the v14.x-staging branch as the instructions for the quic fork use a git clone/checkout of the forked repository while the previous instructions for the non-forked openssl use the release tarball. Remove references to End-of-Life Node.js 10 and update for Node.js 12 as it is necessary to regenerate the configution files.
danbev
approved these changes
Aug 25, 2021
richardlau
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Aug 25, 2021
lpinca
approved these changes
Aug 25, 2021
jasnell
approved these changes
Aug 25, 2021
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 27, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 27, 2021
Landed in 52ebe0f...b5ee5b5 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
Update the maintaining openssl guide to mention following the instructions in the v14.x-staging version of the guide for the v14.x-staging branch as the instructions for the quic fork use a git clone/checkout of the forked repository while the previous instructions for the non-forked openssl use the release tarball. Remove references to End-of-Life Node.js 10 and update for Node.js 12 as it is necessary to regenerate the configution files. PR-URL: #39878 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Update the maintaining openssl guide to mention following the instructions in the v14.x-staging version of the guide for the v14.x-staging branch as the instructions for the quic fork use a git clone/checkout of the forked repository while the previous instructions for the non-forked openssl use the release tarball. Remove references to End-of-Life Node.js 10 and update for Node.js 12 as it is necessary to regenerate the configution files. PR-URL: #39878 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Update the maintaining openssl guide to mention following the instructions in the v14.x-staging version of the guide for the v14.x-staging branch as the instructions for the quic fork use a git clone/checkout of the forked repository while the previous instructions for the non-forked openssl use the release tarball. Remove references to End-of-Life Node.js 10 and update for Node.js 12 as it is necessary to regenerate the configution files. PR-URL: #39878 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the maintaining openssl guide to mention following the
instructions in the v14.x-staging version of the guide for the
v14.x-staging branch as the instructions for the quic fork use
a git clone/checkout of the forked repository while the previous
instructions for the non-forked openssl use the release tarball.
Remove references to End-of-Life Node.js 10 and update for Node.js
12 as it is necessary to regenerate the configution files.