Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update token used for pull requests #39907

Closed
wants to merge 2 commits into from
Closed

build: update token used for pull requests #39907

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 27, 2021

@Trott Trott requested review from bnb and targos August 27, 2021 03:51
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 27, 2021
@Trott Trott mentioned this pull request Aug 27, 2021
Closed
@Trott
Copy link
Member Author

Trott commented Aug 27, 2021

I pushed this PR branch or the actions/authors-update branch on nodejs/node, and then ran the workflow on that branch.

Here's the run: https://github.com/nodejs/node/runs/3439618049

And here's the resulting PR: #39908

In that PR, the GitHub CI ran, so I think this is good to land.

@Trott Trott mentioned this pull request Aug 27, 2021
Closed
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 27, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Mesteery
Copy link
Contributor

Mesteery commented Aug 27, 2021 •
edited
Loading

Can you also change the name and email of the committer by the name and email of the bot?
And there is also find-inactive-collaborators.yml to update. (i just saw the other pr)

@Trott Trott mentioned this pull request Aug 27, 2021
Closed
@Trott
Copy link
Member Author

Trott commented Aug 27, 2021

Can you also change the name and email of the committer by the name and email of the bot?
And there is also find-inactive-collaborators.yml to update. (i just saw the other pr)

What do others think? Node.js github-bot is a separate bot that isn't involved in this, so I'm not sure. github-bot code is at https://github.com/nodejs/github-bot and doesn't use GitHub Actions.

@Mesteery
Copy link
Contributor

Mesteery commented Aug 27, 2021 •
edited
Loading

I just looked at #39908 (in your comment) whose author is @nodejs-github-bot.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2021
@github-actions
Copy link
Contributor

Landed in 660b1d1...e8718b2

@github-actions github-actions bot closed this Aug 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 30, 2021
@Trott @nodejs-github-bot
build: update token used for pull requests
e8718b2 
Refs: #39874 (comment)

PR-URL: #39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Trott @targos
build: update token used for pull requests
fef7211 
Refs: #39874 (comment)

PR-URL: #39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Trott @targos
build: update token used for pull requests
0ff88f3 
Refs: #39874 (comment)

PR-URL: #39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
@Trott Trott deleted the secrets branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@bnb bnb Awaiting requested review from bnb

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @Mesteery @jasnell @lpinca @targos @tniessen @nodejs-github-bot