-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove unnecessary comment and add a CHECK
in crypto_tls.cc
#39991
src: remove unnecessary comment and add a CHECK
in crypto_tls.cc
#39991
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t really see the point of the TODO comment. Inlining the Buffer::New()
function gains us nothing and makes the code more complex. Switching to a plain Uint8Array
, as the comment indicates, would be API breakage, and in particular API breakage that almost certainly isn’t worth ever actually doing.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
Buffer
from crypto::KeylogCallback()
CHECK
in crypto_tls.cc
5060505
to
9a39eb5
Compare
@addaleax |
This comment has been minimized.
This comment has been minimized.
Right, I am saying that I don’t see the need to use either |
Landed in 341312d...604c1df |
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39991 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39991 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39991 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Signed-off-by: Darshan Sen darshan.sen@postman.com