Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] fs: improve fsPromises writeFile performance #39993

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] fs: improve fsPromises writeFile performance #39993

wants to merge 1 commit into from

Conversation

MoritzLoewenstein
Copy link

backport of #37610
'sister' pr of #39838

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v14.x labels Sep 4, 2021
targos
targos approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits to make the code closer to what's on the master branch

lib/internal/fs/promises.js Outdated Show resolved Hide resolved
lib/internal/fs/utils.js Show resolved Hide resolved
lib/internal/fs/utils.js Outdated Show resolved Hide resolved
@MoritzLoewenstein MoritzLoewenstein force-pushed the fs-writefile-performance-backport branch from d51c40c to 91cad74 Compare September 5, 2021 10:13
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39788/

@targos
Copy link
Member

targos commented Sep 5, 2021

CI with Python 2 is broken: #39990 (comment)

@MoritzLoewenstein MoritzLoewenstein force-pushed the fs-writefile-performance-backport branch from 91cad74 to 03d36bb Compare September 5, 2021 14:07
@Linkgoron @targos
fs: improve fsPromises writeFile performance
9a5e60b 
Increase the write chunk size in fsPromises writeFile
to improve performance.

PR-URL: nodejs#37610
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos force-pushed the fs-writefile-performance-backport branch from 03d36bb to 9a5e60b Compare September 7, 2021 09:19
@targos
Copy link
Member

targos commented Sep 7, 2021

I just rebased the branch. CI should pass now.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39849/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39851/

targos pushed a commit that referenced this pull request Sep 7, 2021
@Linkgoron @targos
fs: improve fsPromises writeFile performance
d2834fb 
Increase the write chunk size in fsPromises writeFile
to improve performance.

PR-URL: #37610
Backport-PR-URL: #39993
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
Copy link
Member

targos commented Sep 7, 2021

Landed in d2834fb

@targos targos closed this Sep 7, 2021
@MoritzLoewenstein MoritzLoewenstein deleted the fs-writefile-performance-backport branch September 7, 2021 14:24
This was referenced Sep 14, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@Linkgoron Linkgoron Linkgoron approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MoritzLoewenstein @nodejs-github-bot @targos @Linkgoron