dns: cleanup validation #40061
Closed
dns: cleanup validation #40061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
VoltrexKeyva
force-pushed
the
patch-8
branch
from
4b8896c
to
3a13bf1
Compare
tniessen
reviewed
Sep 10, 2021
aduh95
approved these changes
Sep 10, 2021
aduh95
added
the
semver-major
The `validateString()` validator should cleanup the validation and keep consistency.
VoltrexKeyva
force-pushed
the
patch-8
branch
from
3a13bf1
to
e65a126
Compare
aduh95
removed
the
semver-major
lpinca
approved these changes
Sep 11, 2021
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Sep 13, 2021
This was referenced Sep 14, 2021
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in de10ab2...eb44d19 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 17, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validateString()validator should cleanup the validation and keep consistency.