Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add riscv64 into openssl Makefile and gen openssl-riscv64 #40063

Closed
wants to merge 1 commit into from
Closed

deps: add riscv64 into openssl Makefile and gen openssl-riscv64 #40063

wants to merge 1 commit into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Sep 10, 2021 •
edited
Loading

Add linux64-riscv64 into Makefile
And run make

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Sep 10, 2021
@luyahan luyahan changed the title deps:Add riscv64 into openssl Makefile and gen openssl-riscv64 deps: Add riscv64 into openssl Makefile and gen openssl-riscv64 Sep 10, 2021
@luyahan luyahan changed the title deps: Add riscv64 into openssl Makefile and gen openssl-riscv64 deps: add riscv64 into openssl Makefile and gen openssl-riscv64 Sep 13, 2021
@luyahan
Copy link
Contributor Author

luyahan commented Sep 13, 2021

There is a timeout error. How can i to re-trigger it ?

@targos
Copy link
Member

targos commented Sep 13, 2021

I just did it (only collaborators can re-trigger single jobs)

mhdawson
mhdawson approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39978/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 17, 2021 •
edited by Ayase-252
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39981/ 🟡

Flaky test failed: test-domain-error-types
Refs: #38063 #39368

@Ayase-252
Copy link
Member

node-test-commit-linuxone--enable-lto is still of failure, but it was disable for node-test-pull-request. Should we make sure node-test-commit-linuxone--enable-lto green or land it as it is?

@richardlau
Copy link
Member

node-test-commit-linuxone--enable-lto is still of failure, but it was disable for node-test-pull-request. Should we make sure node-test-commit-linuxone--enable-lto green or land it as it is?

ugh. The LTO build is new (nodejs/build#2758) -- it looks like Jenkins isn't resuming failed/unstable LTO runs (the console says it schedules one but it doesn't seem to result in one being run). Possibly a bug in the multijob plugin with the same job being run with differing parameters.

I've manually rerun the LTO build for this PR.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2021
@github-actions
Copy link
Contributor

Landed in 55379eb...7905df1

@github-actions github-actions bot closed this Sep 17, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2021
@luyahan @nodejs-github-bot
deps: add riscv64 into openssl Makefile and gen openssl-riscv64
7905df1 
PR-URL: #40063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Sep 18, 2021
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@luyahan @BethGriggs
deps: add riscv64 into openssl Makefile and gen openssl-riscv64
7303a10 
PR-URL: #40063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@luyahan @BethGriggs
deps: add riscv64 into openssl Makefile and gen openssl-riscv64
06f6e01 
PR-URL: #40063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Open
Open
Open
@qjivy qjivy mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luyahan @targos @nodejs-github-bot @Ayase-252 @richardlau @jasnell @mhdawson