test: fix internet/test-dns #40083
Closed
test: fix internet/test-dns #40083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internet/test-dns is failing due to a typo that inadvertently sends a boolean instead of a regular expression.
nodejs-github-bot
added
needs-ci
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
|
Only the nightly CI runs the internet tests, so this doesn't show up in our CI runs for PRs. Here it is failing in the nightly run, though: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22314/testReport/junit/(root)/test/internet_test_dns/ |
github-actions
bot
removed
the
request-ci
|
Internet CI against this PR: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22318/ ✅ |
|
@nodjes/testing (Also, if you review, please consider thumbs-upping the fast-track request above!) |
richardlau
approved these changes
Sep 11, 2021
Ayase-252
approved these changes
Sep 11, 2021
tniessen
approved these changes
Sep 11, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in e267467...ec555b0 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2021
internet/test-dns is failing due to a typo that inadvertently sends a boolean instead of a regular expression. PR-URL: #40083 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 14, 2021
This was referenced Sep 16, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
internet/test-dns is failing due to a typo that inadvertently sends a boolean instead of a regular expression. PR-URL: #40083 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
internet/test-dns is failing due to a typo that inadvertently sends a boolean instead of a regular expression. PR-URL: #40083 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.