Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,crypto: eliminate code duplication between StatelessDiffieHellman* #40084

Closed
wants to merge 1 commit into from
Closed

src,crypto: eliminate code duplication between StatelessDiffieHellman* #40084

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 11, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 11, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax reviewed Sep 12, 2021
View reviewed changes
src/crypto/crypto_dh.cc Outdated Show resolved Hide resolved
@RaisinTen RaisinTen force-pushed the src,crypto/eliminate-code-duplication-between-StatelessDiffieHellman branch from 989bbce to 62a4900 Compare September 12, 2021 14:04
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax reviewed Sep 12, 2021
View reviewed changes
src/crypto/crypto_dh.cc Outdated Show resolved Hide resolved
addaleax
addaleax reviewed Sep 12, 2021
View reviewed changes
src/crypto/crypto_dh.cc Outdated Show resolved Hide resolved
@RaisinTen RaisinTen force-pushed the src,crypto/eliminate-code-duplication-between-StatelessDiffieHellman branch from 62a4900 to 114ad72 Compare September 13, 2021 04:44
RaisinTen
RaisinTen commented Sep 13, 2021
View reviewed changes
src/crypto/crypto_dh.cc Outdated Show resolved Hide resolved
@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 13, 2021
This was referenced Sep 14, 2021
Open
Open
Open
Open
Open
@RaisinTen RaisinTen force-pushed the src,crypto/eliminate-code-duplication-between-StatelessDiffieHellman branch 2 times, most recently from 041bb29 to 422740e Compare September 18, 2021 08:45
RaisinTen
RaisinTen commented Sep 18, 2021
View reviewed changes
src/crypto/crypto_dh.cc Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Sep 23, 2021
Open
18 tasks
@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2021
@github-actions github-actions bot mentioned this pull request Sep 24, 2021
Open
15 tasks
@RaisinTen
src,crypto: eliminate code duplication between StatelessDiffieHellman*
914d0aa 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the src,crypto/eliminate-code-duplication-between-StatelessDiffieHellman branch from 422740e to 914d0aa Compare September 24, 2021 13:45
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2021
@github-actions github-actions bot mentioned this pull request Sep 25, 2021
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 25, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40057/ 💚

jasnell pushed a commit that referenced this pull request Sep 25, 2021
@RaisinTen @jasnell
src,crypto: eliminate code duplication between StatelessDiffieHellman*
5ba7fbb 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40084
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 25, 2021

Landed in 5ba7fbb

@jasnell jasnell closed this Sep 25, 2021
@RaisinTen RaisinTen deleted the src,crypto/eliminate-code-duplication-between-StatelessDiffieHellman branch September 25, 2021 14:50
This was referenced Sep 26, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 3, 2021
Open
Open
targos pushed a commit that referenced this pull request Oct 4, 2021
@RaisinTen @targos
src,crypto: eliminate code duplication between StatelessDiffieHellman*
bddf8c2 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40084
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu Awaiting requested review from JungMinu

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaisinTen @nodejs-github-bot @jasnell @addaleax @JungMinu