test: do not run test-corepack-yarn-install with no internet
#40090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Sep 12, 2021
aduh95
added
author ready
tniessen
approved these changes
Sep 12, 2021
targos
approved these changes
Sep 13, 2021
jasnell
approved these changes
Sep 13, 2021
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40090 ✔ Done loading data for nodejs/node/pull/40090 ----------------------------------- PR info ------------------------------------ Title test: do not run `test-corepack-yarn-install` with no internet (#40090) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:yarn-test-internet -> nodejs:master Labels test, author ready Commits 1 - test: do not run `test-corepack-yarn-install` with no internet Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Sep 2021 14:28:37 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40090#pullrequestreview-752188232 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752225082 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752385388 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752782487 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-754083383 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1243446870 |
github-actions
bot
added
the
commit-queue-failed
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
17 tasks
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 2b080cb...3101c09 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 18, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Sep 19, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this test requires internet access to succeed, moving it to the relevant folder. I've also added a line to dump stdout when the test fails as it contains relevant info to understand the failure.