-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: remove CRLF variable #40101
http: remove CRLF variable #40101
Conversation
Welcome, @shfshanyue, and thanks for the pull request. I don't feel terribly strongly about this, but I'm not convinced |
FWIW I'm not particularly fond of having a CRLF string variable either. It'd be better to just include the literal value where needed. |
I think it would be better if change all the usage of |
I prefer an explicit |
a624067
to
e63733b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
No objections, but please do not change it again after this lands. Refs: f4d3d12 |
PR-URL: #40101 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Landed in e9fc678 |
PR-URL: #40101 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40101 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
No description provided.