Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: optimize linux test workflow #40118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: optimize linux test workflow #40118

wants to merge 1 commit into from

Conversation

willin
Copy link

@willin willin commented Sep 15, 2021

add ignored paths. which is from macos and asan

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 15, 2021
@willin willin changed the title ci: optimize linux test workflow build: optimize linux test workflow Sep 15, 2021
Mesteery
Mesteery reviewed Sep 15, 2021
View reviewed changes
.github/workflows/test-linux.yml
@@ -3,6 +3,9 @@ name: test-linux
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
Copy link
Contributor

@Mesteery Mesteery Sep 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to run at least one build for doc changes -- at least one test checks for consistency between documentation and run time (hence needing a built node binary) behaviour:

#39871 (comment)

aduh95
aduh95 requested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the PR. As the other comment says, I don't think we should disable the test-linux workflow as we still want to have those tests run at least once, and it's the build job that takes the least time to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@aduh95 aduh95 aduh95 requested changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willin @aduh95 @Mesteery @nodejs-github-bot