Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix CJS-ESM selector in Safari #40135

Closed
wants to merge 1 commit into from
Closed

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Sep 17, 2021

Safari needs a vendor prefix on the appearance of the checkbox

Screen Shot 2021-09-17 at 09 05 22

@bmeck bmeck added the doc Issues and PRs related to the documentations. label Sep 17, 2021
doc/api_assets/style.css Outdated Show resolved Hide resolved
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 17, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Sep 17, 2021

Landed in 6bfe5a6.

@aduh95 aduh95 closed this Sep 17, 2021
@aduh95 aduh95 deleted the doc-safari-cjs-esm-css branch September 17, 2021 18:28
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 22, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: nodejs#40135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 31, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Backport-PR-URL: #40561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Oct 31, 2021
richardlau pushed a commit that referenced this pull request Nov 25, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Backport-PR-URL: #40561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants