Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove usage of AllocatedBuffer from udp_wrap.cc #40151

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Sep 19, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen force-pushed the src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc branch from 3b8daf8 to 755a3fe Compare September 19, 2021 09:35
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 19, 2021
@nodejs-github-bot

This comment has been minimized.

src/udp_wrap.cc Outdated Show resolved Hide resolved
@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2021
@nodejs-github-bot

This comment has been minimized.

src/udp_wrap.cc Outdated Show resolved Hide resolved
src/udp_wrap.cc Outdated Show resolved Hide resolved
src/udp_wrap.cc Outdated Show resolved Hide resolved
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc branch from c2715b8 to 1865ace Compare September 24, 2021 14:23
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions
Copy link
Contributor

Landed in 256fe21...95d1656

@github-actions github-actions bot closed this Sep 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 26, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-udp_wrap.cc branch September 26, 2021 14:47
targos pushed a commit that referenced this pull request Oct 4, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40151
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants