Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update markdown files in src for upcoming linting/formatting #40159

Merged
merged 1 commit into from
Sep 22, 2021
Merged

doc: update markdown files in src for upcoming linting/formatting #40159

merged 1 commit into from
Sep 22, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 19, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 19, 2021
Trott
Trott commented Sep 19, 2021
View reviewed changes
src/crypto/README.md
@@ -31,7 +31,7 @@ throughout the rest of the code.
The rest of the files are structured by their function, as detailed in the
following table:

| File (*.h/*.cc) | Description |
| File (\*.h/\*.cc) | Description |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fixes a straight-up bug. This currently renders as italics without the * because that's how markdown would process it.

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 20, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40002/

@Trott
doc: update markdown files in src for upcoming linting/formatting
5ca5499 
PR-URL: nodejs#40159
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Sep 22, 2021

Landed in 5ca5499

@Trott Trott merged commit 5ca5499 into nodejs:master Sep 22, 2021
@Trott Trott deleted the src-md branch September 22, 2021 00:04
targos pushed a commit that referenced this pull request Oct 4, 2021
@Trott @targos
doc: update markdown files in src for upcoming linting/formatting
847b451 
PR-URL: #40159
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @jasnell @lpinca @targos @richardlau @aduh95 @HarshithaKP