Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move ToUSVString() to node_util.cc #40204

Closed
wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

Since toUSVString() was exposed in util as a public API, not only
for internal url any more.

Since `toUSVString()` was exposed in `util` as a public API, not only
for internal `url` any more.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 24, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 26, 2021
XadillaX added a commit that referenced this pull request Sep 26, 2021
Since `toUSVString()` was exposed in `util` as a public API, not only
for internal `url` any more.

PR-URL: #40204
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@XadillaX
Copy link
Contributor Author

Landed in 0e561de

@XadillaX XadillaX closed this Sep 26, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
Since `toUSVString()` was exposed in `util` as a public API, not only
for internal `url` any more.

PR-URL: #40204
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants