-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: correct ESM load hook table header #40234
Closed
JakobJingleheimer
wants to merge
1
commit into
nodejs:master
from
JakobJingleheimer:correct-esm-docs-table
Closed
doc: correct ESM load hook table header #40234
JakobJingleheimer
wants to merge
1
commit into
nodejs:master
from
JakobJingleheimer:correct-esm-docs-table
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
labels
Sep 27, 2021
Trott
reviewed
Sep 27, 2021
`resolve` does not return a `source` property
JakobJingleheimer
force-pushed
the
correct-esm-docs-table
branch
from
September 28, 2021 07:22
d323bc6
to
13e4413
Compare
aduh95
approved these changes
Sep 28, 2021
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 29, 2021
juanarbol
approved these changes
Oct 3, 2021
jasnell
approved these changes
Oct 3, 2021
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2021
Landed in d0fa1e9...6199441 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 4, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Added |
targos
pushed a commit
that referenced
this pull request
Oct 9, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 12, 2021
`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
esm
Issues and PRs related to the ECMAScript Modules implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve
does not return asource
propertyfixes nodejs/loaders#35