build: use Clang 12 for test-asan workflow #40238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
This comment has been minimized.
This comment has been minimized.
|
/cc @addaleax @gengjiawen |
addaleax
approved these changes
Sep 28, 2021
tniessen
approved these changes
Sep 28, 2021
RaisinTen
reviewed
Sep 28, 2021
There was a problem hiding this comment.
@targos does asan still complain when we replace memcpys with memmoves?
diff --git a/deps/zlib/zutil.h b/deps/zlib/zutil.h
index 4425bcf75e..312f350011 100644
--- a/deps/zlib/zutil.h
+++ b/deps/zlib/zutil.h
@@ -238,7 +238,7 @@ extern z_const char * const z_errmsg[10]; /* indexed by 2-zlib_error */
# define zmemcmp _fmemcmp
# define zmemzero(dest, len) _fmemset(dest, 0, len)
# else
-# define zmemcpy memcpy
+# define zmemcpy memmove
# define zmemcmp memcmp
# define zmemzero(dest, len) memset(dest, 0, len)
# endif
|
@RaisinTen feel free to push to my branch to try |
|
@addaleax What do you think we should do, then? If I land this, test-asan will be red until someone fixes the issue. |
|
@targos I think somebody needs to reproduce this locally, then figure out which zlib calls exactly are leading to this error. :/ |
targos
added
blocked
gengjiawen
reviewed
Sep 29, 2021
| LINK: clang++ | ||
| CC: clang-12 | ||
| CXX: clang++-12 | ||
| LINK: clang++-12 |
There was a problem hiding this comment.
Is LINK here neccessary ?
Context: https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
There was a problem hiding this comment.
Yeah, it doesn't seem useful. /cc @mmarchini
There was a problem hiding this comment.
I don't remember why LINK was necessary (to force clang linker instead of ld when linking? idk that's the only thing I can think of). We can always remove and see what happens
There was a problem hiding this comment.
I do think it was more of a GitHub Actions thing and less of a gnu thing
There was a problem hiding this comment.
Ok I remember now. ld would consume too much memory for ASAN to be possible on Actions, given the size of the instances available (see #32776). I'm almost sure LINK is not standard but is used by gyp. What I'm not entirely sure is if CXX being set to clang++-12 is enough. Again, someone would need to experiment (specifically looking at peak memory usage when LINK is set or not).
@addaleax This will trigger the ASAN error. Make sure Also I am confused why it's not using debug node since I pass |
|
When I force debug build using |
gengjiawen
reviewed
Sep 29, 2021
| CC: clang | ||
| CXX: clang++ | ||
| LINK: clang++ | ||
| CC: clang-12 |
There was a problem hiding this comment.
Also latest clang is 13. Not sure github action bundled it yet.
There was a problem hiding this comment.
GitHub runners only have clang 10,11 and 12: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#language-and-runtime
There was a problem hiding this comment.
Tried clang-13 locally, same result.
With |
targos
force-pushed
the
asan-clang-12
branch
from
4a57b14 to
6ba702e
Compare
rebased output |
jasnell
approved these changes
Jan 28, 2022
mmarchini
approved these changes
Jan 29, 2022
|
Thank you for the approvals but we still can't merge this because of the error spotted by clang-12. |
targos
added
build
|
It's green now :) Can I have a new review? |
RaisinTen
approved these changes
Apr 30, 2022
I have no idea. |
|
Could it be flaky? I was wondering if we should rerun CI a couple of times before landing. |
|
I force-pushed again to run with latest master (will need another review to land). We can then rerun it a couple times. |
RaisinTen
approved these changes
Apr 30, 2022
tniessen
approved these changes
Apr 30, 2022
|
Green. Rerunning... |
|
You were right, it's flaky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have issues with the default (version 11) in the PR to update V8: #39945
I hope it will fail here too and someone knows how to fix it :)