Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update AUTHORS #40289

Closed
wants to merge 1 commit into from
Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js and submits a new PR or updates an existing PR.

Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 3, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for duplicates and none of these are duplicates. LGTM.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 3, 2021
@Lxxyx Lxxyx added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Commit Queue failed
- Loading data for nodejs/node/pull/40289
✔  Done loading data for nodejs/node/pull/40289
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#40289)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta, fast-track
Commits    1
 - meta: update AUTHORS
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/40289
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Zijian Liu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40289
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Zijian Liu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 03 Oct 2021 00:14:51 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40289#pullrequestreview-769539360
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40289#pullrequestreview-769554392
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40289#pullrequestreview-769561892
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1300138966

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 3, 2021
Lxxyx pushed a commit to Lxxyx/node that referenced this pull request Oct 3, 2021
PR-URL: nodejs#40289
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Lxxyx
Copy link
Member

Lxxyx commented Oct 3, 2021

Landed in 5ae72b7

@Lxxyx Lxxyx closed this Oct 3, 2021
@targos targos deleted the actions/authors-update branch October 3, 2021 09:06
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40289
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants