-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: remove incorrect constructor invocation #40300
Conversation
Thanks for the PR. Could you add a regression test please. |
@panva Thank you so much for that! I tried to setup nodejs locally to properly test it, but ran into many issues/errors and didn't have time to continue trying to get it working today. |
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Landed in 28f711b |
Thank you for your contribution @gc! |
@gc do you mind backporting this PR? It broke the v16.x build. thanks! |
@danielleadams i can help, which branch do I base off of and open a PR against? |
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The test failed on v16.x-staging because the diff --git a/test/parallel/test-webcrypto-ed25519-ed448.js b/test/parallel/test-webcrypto-ed25519-ed448.js
index a0d858a4ab..b18f3f9d3b 100644
--- a/test/parallel/test-webcrypto-ed25519-ed448.js
+++ b/test/parallel/test-webcrypto-ed25519-ed448.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
'use strict';
const common = require('../common');
@@ -11,6 +12,9 @@ const {
webcrypto: { subtle }
} = require('crypto');
+const { internalBinding } = require('internal/test/binding');
+const { DOMException } = internalBinding('messaging');
+
async function generateKey(namedCurve) {
return subtle.generateKey(
{ |
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This line is incorrectly trying to do
throw new lazyDOMException
, causing it to throw the wrong error.Reproduction: