v16.11.0 release proposal

.eslintignore

@@ -4,8 +4,7 @@ test/addons/??_*
 test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
-tools/lint-md.mjs
-tools/node-lint-md-cli-rollup/dist
+tools/lint-md/lint-md.mjs
 benchmark/tmp
 doc/**/*.js
 !.eslintrc.js

.github/label-pr-config.yml

@@ -103,9 +103,9 @@ subSystemLabels:
   /^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x
 
   # All other lib/ files map directly
-  /^lib\/_(\w+)_\w+\.js?$/: $1 # e.g. _(stream)_wrap
-  /^lib(\/internal)?\/(\w+)\.js?$/: $2 # other .js files
-  /^lib\/internal\/(\w+)(?:\/|$)/: $1 # internal subfolders
+  /^lib\/_(\w+)_\w+\.js?$/: $1  # e.g. _(stream)_wrap
+  /^lib(\/internal)?\/(\w+)\.js?$/: $2  # Other .js files
+  /^lib\/internal\/(\w+)(?:\/|$)/: $1  # internal subfolders
 
 exlusiveLabels:
   # more specific tests
@@ -125,26 +125,26 @@ exlusiveLabels:
 
   /^test\//: test
 
-    # specific map for webcrypto.md as it should be labeled 'crypto'
+  # Specific map for webcrypto.md as it should be labeled 'crypto'
   /^doc\/api\/webcrypto.md$/: doc, crypto
-    # specific map for modules.md as it should be labeled 'module' not 'modules'
+  # Specific map for modules.md as it should be labeled 'module' not 'modules'
   /^doc\/api\/modules.md$/: doc, module
-    # node-api is treated separately since it is not a JS core module but is still
-    # considered a subsystem of sorts
+  # node-api is treated separately since it is not a JS core module but is still
+  # considered a subsystem of sorts
   /^doc\/api\/n-api.md$/: doc, node-api
-    # quic
+  # quic
   /^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
-    # add worker label to PRs that affect doc/api/worker_threads.md
+  # Add worker label to PRs that affect doc/api/worker_threads.md
   /^doc\/api\/worker_threads.md$/: doc, worker
-    # automatically tag JS subsystem-specific API doc changes
+  # Automatically tag JS subsystem-specific API doc changes
   /^doc\/api\/(\w+)\.md$/: doc, $1
-    # add deprecations label to PRs that affect doc/api/deprecations.md
+  # Add deprecations label to PRs that affect doc/api/deprecations.md
   /^doc\/api\/deprecations.md$/: doc, deprecations
   /^doc\/changelogs\//: release
 
   /^doc\//: doc
 
-    # more specific benchmarks
+  # More specific benchmarks
   /^benchmark\/buffers\//: benchmark, buffer
   /^benchmark\/(?:arrays|es)\//: benchmark, v8 engine
   /^benchmark\/_http/: benchmark, http

.github/workflows/authors.yml

@@ -8,19 +8,31 @@ on:
 
 jobs:
   authors_update:
+    if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
         with:
-          fetch-depth: '0' # this is required to actually get all the authors
-      - run: "tools/update-authors.js" # run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@v1 # create a PR or update the Action's existing PR
+          fetch-depth: '0'  # This is required to actually get all the authors
+      - run: "tools/update-authors.js"  # Run the AUTHORS tool
+      - name: "Check for duplicates"
+        run: |
+          PATTERN_FILE=`mktemp`;
+          git diff | egrep '^\+[^+]' | perl -pe 's/^\+(.+?) <.+\n/\1\n/g' > $PATTERN_FILE;
+          DUPLICATES=`grep -F -f $PATTERN_FILE AUTHORS | cut -d'<' -f1 | sort | uniq -c | sort -n | grep -v '^ *1 ' | perl -pe 's/^ *\d+ / /'`; # Last part here substitues a space at the start of each line
+          echo 'DUPLICATES<<EOF' >> $GITHUB_ENV
+          if [ ! -z "${DUPLICATES}" ]; then
+            echo "The following may be duplicates; consider adding a .mailmap entry for them:" >> $GITHUB_ENV;
+            echo "${DUPLICATES}" >> $GITHUB_ENV;
+          fi;
+          echo 'EOF' >> $GITHUB_ENV; # Each line of duplicates starts with a space, so it won't conflict with 'EOF'
+      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <github-bot@iojs.org>
-          body: "If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the `authors.yml` GitHub Action, which runs `tools/update-authors.js` and submits a new PR or updates an existing PR.\n\nPlease note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR."
-          branch: "actions/authors-update" # custom branch *just* for this Action.
+          body: "Here are some new additions to the AUTHORS file. This is an automatically generated PR by the `authors.yml` GitHub Action, which runs `tools/update-authors.js`.\n\n{{ env.DUPLICATES }}"
+          branch: "actions/authors-update"  # Custom branch *just* for this Action.
           commit-message: "meta: update AUTHORS"
           labels: meta
           title: "meta: update AUTHORS"

.github/workflows/auto-start-ci.yml

@@ -1,4 +1,3 @@
----
 name: Auto Start CI
 
 on:

.github/workflows/build-tarball.yml

@@ -27,7 +27,7 @@ jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
     env:
-      PYTHON_VERSION: 3.9
+      PYTHON_VERSION: '3.10'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -52,7 +52,7 @@ jobs:
           path: tarballs
   test-tarball-linux:
     env:
-      PYTHON_VERSION: 3.9
+      PYTHON_VERSION: '3.10'
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:

.github/workflows/build-windows.yml

@@ -12,7 +12,7 @@ on:
       - v[0-9]+.x
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/close-stalled.yml

@@ -1,26 +1,26 @@
 name: Close stalled issues and PRs
 on:
   schedule:
-  - cron: "0 0 * * *"
+    - cron: "0 0 * * *"
 
 jobs:
   stale:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/stale@v3
-      with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
-        days-before-close: 30
-        stale-pr-label: stalled
-        stale-issue-label: stalled
-        close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
-        close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
-        # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues
-        only-labels: stalled
-        # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
-        operations-per-run: 500
-        # deactivates automatic removal of stalled label if issue gets any activity
-        remove-stale-when-updated: false
-        # deactivates automatic stale labelling as we prefer to do that manually
-        days-before-stale: -1
+      - uses: actions/stale@v3
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          days-before-close: 30
+          stale-pr-label: stalled
+          stale-issue-label: stalled
+          close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
+          close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
+          # used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues
+          only-labels: stalled
+          # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits
+          operations-per-run: 500
+          # deactivates automatic removal of stalled label if issue gets any activity
+          remove-stale-when-updated: false
+          # deactivates automatic stale labelling as we prefer to do that manually
+          days-before-stale: -1

.github/workflows/commit-queue.yml

@@ -1,4 +1,3 @@
----
 # This action requires the following secrets to be set on the repository:
 #   GH_USER_NAME: GitHub user whose Jenkins and GitHub token are defined below
 #   GH_USER_TOKEN: GitHub user token, to be used by ncu and to push changes

.github/workflows/coverage-linux.yml

@@ -19,7 +19,7 @@ on:
       - 'doc/**'
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/coverage-windows.yml

@@ -21,7 +21,7 @@ on:
       - 'tools/**'
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/license-builder.yml

@@ -12,8 +12,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - run: "./tools/license-builder.sh" # run the license builder tool
-      - uses: gr2m/create-or-update-pull-request-action@v1.x # create a PR or update the Action's existing PR
+      - run: "./tools/license-builder.sh"  # Run the license builder tool
+      - uses: gr2m/create-or-update-pull-request-action@v1.x  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/linters.yml

@@ -11,7 +11,7 @@ on:
       - v[0-9]+.x
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   NODE_VERSION: lts/*
 
 jobs:
@@ -55,7 +55,7 @@ jobs:
       - name: Get release version numbers
         if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }}
         id: get-released-versions
-        run: ./tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs
+        run: ./tools/lint-md/list-released-versions-from-changelogs.mjs
       - name: Lint docs
         run: |
           echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"

.github/workflows/test-asan.yml

@@ -22,7 +22,7 @@ on:
       - 'doc/**'
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/test-internet.yml

@@ -5,10 +5,10 @@ on:
   schedule:
     - cron: 5 0 * * *
 
-pull_request:
-  types: [opened, synchronize, reopened, ready_for_review]
-  paths:
-    - test/internet/**
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
+    paths:
+      - test/internet/**
   push:
     branches:
       - master
@@ -20,7 +20,7 @@ pull_request:
       - test/internet/**
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/test-linux.yml

@@ -12,7 +12,7 @@ on:
       - v[0-9]+.x
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.github/workflows/test-macos.yml

@@ -22,7 +22,7 @@ on:
       - 'doc/**'
 
 env:
-  PYTHON_VERSION: 3.9
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:

.mailmap

@@ -142,7 +142,8 @@ Felix Geisendörfer <felix@debuggable.com>
 Felix Geisendörfer <felix@debuggable.com>
 Flandre Scarlet <panyilinlove@qq.com>
 Florian Margaine <florian@margaine.com>
-Forrest L Norvell <forrest@npmjs.com> <ogd@aoaioxxysz.net>
+Forrest L Norvell <othiym23@gmail.com> <forrest@npmjs.com>
+Forrest L Norvell <othiym23@gmail.com> <ogd@aoaioxxysz.net>
 Franziska Hinkelmann <franziska.hinkelmann@gmail.com> <fhinkel@vt.edu>
 Friedemann Altrock <frodenius@gmail.com>
 Fuji Goro <gfuji@cpan.org>
@@ -153,6 +154,7 @@ garygsc <garygsc@gmail.com> <GaryGSC@users.noreply.github.com>
 Geoffrey Booth <webadmin@geoffreybooth.com> <GeoffreyBooth@users.noreply.github.com>
 Geoffrey Booth <webadmin@geoffreybooth.com> <webmaster@geoffreybooth.com>
 Geoffrey Bugaisky <gbugaisk@gmail.com>
+George Adams <gadams@microsoft.com> <george.adams@uk.ibm.com>
 Gerhard Stöbich <deb2001-github@yahoo.de>
 Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com>
 Gil Pedersen <git@gpost.dk> <github@gpost.dk>
@@ -188,7 +190,10 @@ James Hartig <fastest963@gmail.com> <james.hartig@grooveshark.com>
 James M Snell <jasnell@gmail.com>
 James Nimlos <james@nimlos.com>
 Jan Krems <jan.krems@gmail.com> <jan.krems@groupon.com>
+Jem Bezooyen <github@jem.dev> <jem@hipmedia.ca>
+Jem Bezooyen <github@jem.dev> <jem@sendwithus.com>
 Jenna Vuong <jennavuong@gmail.com> <hello@jennavuong.com>
+Jennifer Bland <ratracegrad@gmail.com> <jennifer.bland@sbdinc.com>
 JeongHoon Byun <outsideris@gmail.com>
 Jered Schmidt <tr@nslator.jp>
 Jeremiah Senkpiel <fishrock123@rocketmail.com>
@@ -197,6 +202,7 @@ Jérémy Lal <kapouer@melix.org> <holisme@gmail.com>
 Jerry Chin <qinjia@outlook.com>
 Jessica Quynh Tran <jessica.quynh.tran@gmail.com>
 Jesús Leganés-Combarro 'piranna <piranna@gmail.com>
+Jimb Esser <wasteland@gmail.com> <jimb@railgun3d.com>
 Joe Shaw <joe@joeshaw.org> <joeshaw@litl.com>
 Johan Bergström <bugs@bergstroem.nu>
 Johan Dahlberg <jfd@distrop.com> <dahlberg.johan@gmail.com>
@@ -215,6 +221,7 @@ Jonathan Persson <persson.jonathan@gmail.com> <jonathan.persson@creuna.se>
 Jonathan Rentzsch <jwr.git@redshed.net>
 Jose Luis Vivero <josluivivgar@gmail.com>
 Joseph Leon <joseph.leon.9@gmail.com>
+Josh Dague <jd@josh3736.net> <daguej@email.uc.edu>
 Josh Erickson <josh@snoj.us>
 Josh Hunter <jopann@gmail.com>
 Joshua S. Weinstein <josher19@users.sf.net>
@@ -246,8 +253,11 @@ Kiyoshi Nomo <tokyoincidents.g@gmail.com>
 Koichi Kobayashi <koichik@improvement.jp>
 Kostiantyn Wandalen <wandalen.me@gmail.com>
 Kris Kowal <kris.kowal@cixar.com>
+Kunal Pathak <Kunal.Pathak@microsoft.com> <kpathak@microsoft.com>
 Kyle Robinson Young <kyle@dontkry.com>
+Lakshmi Swetha Gopireddy <lakshmiswethagopireddy@gmail.com> <lakshmigopireddy@in.ibm.com>
 Lakshmi Swetha Gopireddy <lakshmiswethagopireddy@gmail.com> <lgopired@in.ibm.com>
+Lars-Magnus Skog <ralphtheninja@riseup.net> <lars.magnus.skog@gmail.com>
 Leeseean Chiu <leeseean@qq.com>
 Lucas Pardue <lucaspardue.24.7@gmail.com> <lucas.pardue@bbc.co.uk>
 Luke Bayes <lbayes@patternpark.com>

.yamllint.yaml

@@ -1,8 +1,15 @@
-extends: relaxed
+extends: default
 
 rules:
+  document-start:
+    present: false
   line-length: disable
+  truthy:
+    allowed-values: ['true', 'false', 'on', 'off']
 
 ignore: |
   /deps/
   node_modules/
+  /test/fixtures/wpt/
+  /tools/gyp/
+  /tools/pip/