doc,src: update crypto/README.md #40332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Oct 5, 2021
panva
approved these changes
Oct 5, 2021
Lxxyx
approved these changes
Oct 6, 2021
Ayase-252
approved these changes
Oct 6, 2021
Ayase-252
added
author ready
|
Fast-track has been requested by @Ayase-252. Please 👍 to approve. |
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40332 ✔ Done loading data for nodejs/node/pull/40332 ----------------------------------- PR info ------------------------------------ Title doc,src: update crypto/README.md (#40332) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:src-crypto-readme-ecdh-ec -> nodejs:master Labels fast-track, author ready Commits 1 - doc,src: update crypto/README.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40332 Reviewed-By: Luigi Pinca Reviewed-By: Filip Skokan Reviewed-By: Zijian Liu Reviewed-By: Qingyu Deng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40332 Reviewed-By: Luigi Pinca Reviewed-By: Filip Skokan Reviewed-By: Zijian Liu Reviewed-By: Qingyu Deng -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 05 Oct 2021 14:07:49 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40332#pullrequestreview-771780799 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/40332#pullrequestreview-771868688 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40332#pullrequestreview-772216560 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/40332#pullrequestreview-773116029 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1314590958 |
github-actions
bot
added
the
commit-queue-failed
Refs: nodejs#37048 PR-URL: nodejs#40332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Trott
force-pushed
the
src-crypto-readme-ecdh-ec
branch
from
d8517e4 to
055311a
Compare
|
Landed in 055311a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to #37048.