Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: increase crypto DSA keygen params #40416

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Oct 11, 2021

OpenSSL 3.0 increased the minimum values for these parameters.

Fixes: #40410

@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Oct 11, 2021
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

OpenSSL 3.0 increased the minimum values for these parameters.

PR-URL: nodejs#40416
Fixes: nodejs#40410
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@mscdex mscdex merged commit ed01811 into nodejs:master Oct 16, 2021
@mscdex mscdex deleted the benchmark-crypto-fix-error branch October 16, 2021 10:10
targos pushed a commit that referenced this pull request Nov 4, 2021
OpenSSL 3.0 increased the minimum values for these parameters.

PR-URL: #40416
Fixes: #40410
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto keygen benchmark failing after OpenSSL 3.0 upgrade
8 participants