Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tls-no-rsa-key flakiness #4043

Closed
wants to merge 1 commit into from
Closed

test: fix tls-no-rsa-key flakiness #4043

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

It tries to fix this error I've received several times in OS X:

=== release test-tls-no-rsa-key ===                                            
Path: parallel/test-tls-no-rsa-key
events.js:142
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:873:11)
    at TLSWrap.onread (net.js:545:26)

It's the same fix as in #3966

@mscdex mscdex added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. labels Nov 26, 2015
bnoordhuis
bnoordhuis reviewed Dec 1, 2015
View reviewed changes
test/parallel/test-tls-no-rsa-key.js
server.close();
});

c.on('data', function(data) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap the callback in common.mustCall(...)? LGTM apart from that.

@santigimeno
test: fix tls-no-rsa-key flakiness
e782a65 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.
@santigimeno
Copy link
Member Author

PR updated with `common.mustCall'. Thanks

@bnoordhuis
Copy link
Member

LGTM, thanks. CI: https://ci.nodejs.org/job/node-test-pull-request/902/

@santigimeno
Copy link
Member Author

ping :)

@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

whoops! sorry @santigimeno looks like this one slipped through. New CI run just to make sure nothing changed since last time: https://ci.nodejs.org/job/node-test-pull-request/1507/

jasnell pushed a commit that referenced this pull request Feb 2, 2016
@santigimeno @jasnell
test: fix tls-no-rsa-key flakiness
61fe86b 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: #4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

Landed in 61fe86b

@jasnell jasnell closed this Feb 2, 2016
@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

oh, LGTM :-)

@santigimeno
Copy link
Member Author

Thanks!

MylesBorins pushed a commit that referenced this pull request Feb 5, 2016
@santigimeno
test: fix tls-no-rsa-key flakiness
3281c58 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: #4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@santigimeno @rvagg
test: fix tls-no-rsa-key flakiness
a62ace9 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: #4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@santigimeno
test: fix tls-no-rsa-key flakiness
1ea40ac 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: #4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@santigimeno
test: fix tls-no-rsa-key flakiness
c4f98bb 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: nodejs#4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
@santigimeno @MylesBorins
test: fix tls-no-rsa-key flakiness
7fcd425 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: nodejs#4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@santigimeno
test: fix tls-no-rsa-key flakiness
f205e99 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: nodejs#4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@santigimeno
test: fix tls-no-rsa-key flakiness
0f86b74 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: nodejs#4043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@santigimeno @bnoordhuis @jasnell @mscdex @MylesBorins