Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: allow passing delay to timer.refresh() #40434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

timers: allow passing delay to timer.refresh() #40434

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Oct 12, 2021

No description provided.

@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 12, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 12, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex mscdex force-pushed the timers-refresh-args branch from 7ddac5c to 10d58e7 Compare October 12, 2021 23:10
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex mscdex force-pushed the timers-refresh-args branch from 10d58e7 to 18ddfd5 Compare October 12, 2021 23:31
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex mscdex force-pushed the timers-refresh-args branch from 18ddfd5 to b959c50 Compare October 12, 2021 23:41
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos
Copy link
Member

targos commented Oct 13, 2021

@nodejs/timers

@mscdex mscdex force-pushed the timers-refresh-args branch from b959c50 to 29f5a66 Compare October 13, 2021 10:17
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40279/

This was referenced Oct 14, 2021
Open
Open
Open
Open
Open
Open
Open
@jasnell
Copy link
Member

jasnell commented Oct 20, 2021

@mscdex ... can I ask you to provide a short change description and rationale?

benjamingr
benjamingr previously requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know why/for what this is useful before this is merged?

Like - I know there is probably a reasonable use case for this but I don't know what it is

@mscdex
Copy link
Contributor Author

mscdex commented Apr 26, 2022

@benjamingr In my particular case I have a queue of waiting tasks, each with varying start timestamps. With the changes in this PR I can reuse a single timer object for the entire queue and simply do something like timer.refresh(Date.now() - nextTask.startTime).

@mscdex mscdex force-pushed the timers-refresh-args branch 2 times, most recently from a4510d4 to efff092 Compare April 26, 2022 19:46
@benjamingr benjamingr dismissed their stale review April 26, 2022 23:14

meh, ok I guess

@mscdex mscdex force-pushed the timers-refresh-args branch from efff092 to 1ae03a2 Compare April 27, 2022 13:48
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43721/

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 27, 2022
@mscdex mscdex force-pushed the timers-refresh-args branch from 1ae03a2 to 4ed6584 Compare April 27, 2022 14:27
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43723/

@mscdex
Copy link
Contributor Author

mscdex commented Apr 27, 2022

@jasnell I'm not sure what you're asking for. Were you just interested in hearing a use case like @benjamingr ?

This was referenced Apr 28, 2022
Open
Open
Open
Open
Open
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr left review comments

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mscdex @nodejs-github-bot @targos @jasnell @aduh95 @benjamingr @juanarbol