doc: enable GFM footnotes in docs #40477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Trott
commented
Oct 16, 2021
Trott
commented
nodejs-github-bot
added
doc
aduh95
reviewed
Oct 16, 2021
aduh95
approved these changes
Oct 16, 2021
Mesteery
added
the
author ready
Trott
added
commit-queue
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40477 ✔ Done loading data for nodejs/node/pull/40477 ----------------------------------- PR info ------------------------------------ Title doc: enable GFM footnotes in docs (#40477) Author Rich Trott (@Trott) Branch Trott:doc-gfm-fn -> nodejs:master Labels doc, tools, author ready Commits 2 - tools: udpate doc tools to accommodate GFM footnotes - doc: use GFM footnotes in webcrypto.md Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40477 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40477 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: udpate doc tools to accommodate GFM footnotes ⚠ - doc: use GFM footnotes in webcrypto.md ℹ This PR was created on Sat, 16 Oct 2021 04:51:11 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40477#pullrequestreview-781345331 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1375526470 |
PR-URL: nodejs#40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in a536de4...a749c1f. |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40477 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.