Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: enable GFM footnotes in docs #40477

Merged
merged 2 commits into from
Oct 23, 2021
Merged

doc: enable GFM footnotes in docs #40477

merged 2 commits into from
Oct 23, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 16, 2021

tools: udpate doc tools to accommodate GFM footnotes

doc: use GFM footnotes in webcrypto.md

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 16, 2021
tools/doc/allhtml.mjs Outdated Show resolved Hide resolved
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2021
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 23, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 23, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40477
✔  Done loading data for nodejs/node/pull/40477
----------------------------------- PR info ------------------------------------
Title      doc: enable GFM footnotes in docs (#40477)
Author     Rich Trott  (@Trott)
Branch     Trott:doc-gfm-fn -> nodejs:master
Labels     doc, tools, author ready
Commits    2
 - tools: udpate doc tools to accommodate GFM footnotes
 - doc: use GFM footnotes in webcrypto.md
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40477
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: udpate doc tools to accommodate GFM footnotes
   ⚠  - doc: use GFM footnotes in webcrypto.md
   ℹ  This PR was created on Sat, 16 Oct 2021 04:51:11 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40477#pullrequestreview-781345331
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1375526470

PR-URL: nodejs#40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 23, 2021

Landed in a536de4...a749c1f.

@Trott Trott merged commit a749c1f into nodejs:master Oct 23, 2021
@Trott Trott deleted the doc-gfm-fn branch October 23, 2021 13:15
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
PR-URL: #40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
PR-URL: #40477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants