Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] deps: add corepack #40479

Closed
wants to merge 3 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 16, 2021

Bakport of #39608 and #40374.
EDIT: and #41060.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v14.x labels Oct 16, 2021
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 16, 2021
configure.py Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

@nodejs/lts Are we comfortable landing this in 14 LTS now it is in maintenance?

@mhdawson
Copy link
Member

mhdawson commented Dec 7, 2021

I'll add to @richardlau's question, has there been an ask to backport?

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 8, 2021

has there been an ask to backport?

I guess I'm asking for it with this PR.

@arcanis Do you have any thoughts on Corepack making it or not to v14.x?

@arcanis
Copy link
Contributor

arcanis commented Dec 8, 2021

I think it'd be great, since with Node 12 being out of the picture in May it would help providing consistent and portable install instructions for Yarn (we already recommend it if possible, but since Yarn 3 supports Node 12+ and Yarn 4 will support 14+, there's always a good portion of our users which will need other means).

And given it's still opt-in, it should be fairly low-risk (the Corepack tests run on 14+, so it shouldn't have compat issues).

configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
arcanis and others added 3 commits January 14, 2022 18:14
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.

Refs: nodejs#15244
Refs: nodejs/TSC#904

PR-URL: nodejs#39608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#40374
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#41060
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2022
@nodejs-github-bot
Copy link
Collaborator

richardlau pushed a commit that referenced this pull request Jan 25, 2022
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.

Refs: #15244
Refs: nodejs/TSC#904

PR-URL: #39608
Backport-PR-URL: #40479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #40374
Backport-PR-URL: #40479
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41060
Backport-PR-URL: #40479
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@richardlau
Copy link
Member

Landed in b85aa5a...0231ffa.

@richardlau richardlau closed this Jan 25, 2022
@aduh95 aduh95 deleted the backport-corepack branch January 25, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants