[v14.x backport] deps: add corepack #40479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
targos
added
the
semver-minor
richardlau
force-pushed
the
v14.x-staging
branch
from
b5b66ef to
1f48dd8
Compare
aduh95
force-pushed
the
backport-corepack
branch
from
1c76cff to
be6c04b
Compare
richardlau
reviewed
Dec 7, 2021
|
@nodejs/lts Are we comfortable landing this in 14 LTS now it is in maintenance? |
|
I'll add to @richardlau's question, has there been an ask to backport? |
I guess I'm asking for it with this PR. @arcanis Do you have any thoughts on Corepack making it or not to v14.x? |
|
I think it'd be great, since with Node 12 being out of the picture in May it would help providing consistent and portable install instructions for Yarn (we already recommend it if possible, but since Yarn 3 supports Node 12+ and Yarn 4 will support 14+, there's always a good portion of our users which will need other means). And given it's still opt-in, it should be fairly low-risk (the Corepack tests run on 14+, so it shouldn't have compat issues). |
aduh95
commented
Dec 8, 2021
richardlau
force-pushed
the
v14.x-staging
branch
from
495dde6 to
cede1f2
Compare
Corepack provides shims for Yarn and pnpm in order to soften the developer experience when working on Node projects. Refs: nodejs#15244 Refs: nodejs/TSC#904 PR-URL: nodejs#39608 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#40374 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#41060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
force-pushed
the
backport-corepack
branch
from
4adf5bc to
a487d29
Compare
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jan 25, 2022
richardlau
pushed a commit
that referenced
this pull request
Jan 25, 2022
Corepack provides shims for Yarn and pnpm in order to soften the developer experience when working on Node projects. Refs: #15244 Refs: nodejs/TSC#904 PR-URL: #39608 Backport-PR-URL: #40479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #40374 Backport-PR-URL: #40479 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in b85aa5a...0231ffa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bakport of #39608 and #40374.
EDIT: and #41060.