test: add semicolon after chunk size #40487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
|
lpinca
force-pushed
the
add/semicolon-after-chunk-size
branch
2 times, most recently
from
dbaa93b to
5b3a3ac
Compare
The ABNF for chunk extensions as per RFC 7230 is
chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
chunk-ext-name = token
chunk-ext-val = token / quoted-string
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
lpinca
force-pushed
the
add/semicolon-after-chunk-size
branch
from
5b3a3ac to
c7ee409
Compare
27 tasks
jasnell
approved these changes
Oct 20, 2021
This was referenced Oct 21, 2021
44 tasks
This was referenced Nov 5, 2021
lpinca
added a commit
that referenced
this pull request
Nov 6, 2021
The ABNF for chunk extensions as per RFC 7230 is
chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
chunk-ext-name = token
chunk-ext-val = token / quoted-string
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
PR-URL: #40487
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 19839f8. |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
The ABNF for chunk extensions as per RFC 7230 is
chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
chunk-ext-name = token
chunk-ext-val = token / quoted-string
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
PR-URL: #40487
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 7, 2021
23 tasks
26 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
The ABNF for chunk extensions as per RFC 7230 is
chunk-ext = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
chunk-ext-name = token
chunk-ext-val = token / quoted-string
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
PR-URL: #40487
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABNF for chunk extensions as per RFC 7230 is
Add a semicolon after the chunk size for clarity.
This does not invalidate the test as it verifies that the HTTP parser
does not ignore chunk extensions.
Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling