Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: consolidate AUTHORS entries for cxreg #40490

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 17, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 17, 2021
@Trott
Copy link
Member Author

Trott commented Oct 17, 2021

@cxreg This change removes your nodesource.com email address and leaves your pobox.com address in AUTHORS. If you'd prefer the opposite, let me know. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2021
PR-URL: nodejs#40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Trott Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2021
@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

Landed in 2bed031

@Trott Trott merged commit 2bed031 into nodejs:master Oct 19, 2021
@Trott Trott deleted the authors-do branch October 19, 2021 13:11
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
PR-URL: #40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants