build: include missing V8 headers in distribution #40526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@targos I think |
|
I can also verify that v8-weak-callback-info.h needs to be added to that list (is referenced from v8-persistent-handle.h https://github.com/nodejs/node/blob/master/deps/v8/include/v8-persistent-handle.h#L10), and then I think, at least my code, builds fine. |
targos
force-pushed
the
fix-v8-install-headers
branch
from
a7ce196
to
dd85e18
Compare
targos
added
fast-track
|
Fast-track has been requested by @targos. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
|
Can I have some reviews? I'd like to make a quick release to fix Node.js native addons. |
richardlau
approved these changes
Oct 20, 2021
richardlau
approved these changes
Oct 20, 2021
|
@nodejs/releasers @nodejs/tsc is one of you available to review (and approve fast-tracking)? |
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in a397009...3ec3ba5 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fixes: nodejs/Release#704 PR-URL: #40526 Fixes: #40529 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
added a commit
that referenced
this pull request
Oct 20, 2021
Fixes: nodejs/Release#704 PR-URL: #40526 Fixes: #40529 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
added a commit
that referenced
this pull request
Oct 20, 2021
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
targos
added a commit
that referenced
this pull request
Oct 20, 2021
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
30 tasks
12 tasks
This was referenced Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/Release#704
Fixes: #40529