Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for dfabulich #40527

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for dfabulich #40527

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 19, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 19, 2021
@Trott
Copy link
Member Author

Trott commented Oct 19, 2021

@dfabulich This uses a .mailmap entry to preserve your fabulich.com email address in AUTHORS and remove your redfin.com email address there. If you'd prefer we do the opposite, please leave a comment. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2021
@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2021
aduh95
aduh95 approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2021
@github-actions
Copy link
Contributor

Landed in dd7a929...36663c9

nodejs-github-bot pushed a commit that referenced this pull request Oct 22, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for dfabulich
36663c9 
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot closed this Oct 22, 2021
targos pushed a commit that referenced this pull request Oct 23, 2021
@Trott @targos
meta: consolidate AUTHORS entries for dfabulich
ba9a6c5 
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entries for dfabulich
a5475df 
PR-URL: #40527
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@Trott Trott deleted the authors-df branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @lpinca @aduh95 @nodejs-github-bot @Mesteery