Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link in onboarding doc #40539

Merged
merged 1 commit into from
Oct 22, 2021
Merged

update link in onboarding doc #40539

merged 1 commit into from
Oct 22, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 21, 2021

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 21, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 21, 2021
@mscdex
Copy link
Contributor

mscdex commented Oct 21, 2021

s/onbaording/onboarding/ in commit message

@Trott Trott changed the title update link in onbaording doc update link in onboarding doc Oct 21, 2021
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40539
✔  Done loading data for nodejs/node/pull/40539
----------------------------------- PR info ------------------------------------
Title      update link in onboarding doc (#40539)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:master
Labels     doc, fast-track
Commits    1
 - doc: update link in onboarding doc
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 02:01:29 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1367452046

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40539
✔  Done loading data for nodejs/node/pull/40539
----------------------------------- PR info ------------------------------------
Title      update link in onboarding doc (#40539)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:master
Labels     doc, fast-track, author ready
Commits    1
 - doc: update link in onboarding doc
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 02:01:29 GMT
   ✔  Approvals: 5
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785826483
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785858072
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40539#pullrequestreview-786091650
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1369553323

PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott-patch-1 branch 2 times, most recently from 7853180 to 0d59d0d Compare October 22, 2021 05:11
@Trott
Copy link
Member Author

Trott commented Oct 22, 2021

Landed in 0d59d0d

@Trott Trott merged commit 0d59d0d into master Oct 22, 2021
@Trott Trott deleted the Trott-patch-1 branch October 22, 2021 05:12
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants