-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: add mising initialization #40555
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <mdawson@devrus.com>
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Oct 21, 2021
@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct. |
addaleax
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@addaleax thanks, pushed a commit to remove the move. |
addaleax
approved these changes
Oct 25, 2021
30 tasks
This was referenced Oct 29, 2021
tniessen
approved these changes
Nov 2, 2021
Nit: typo in commit message |
42 tasks
This was referenced Nov 4, 2021
26 tasks
This was referenced Nov 11, 2021
mhdawson
added a commit
that referenced
this pull request
Nov 12, 2021
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Landed in |
This was referenced Nov 13, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Add missing initialization reported by coverity scan. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing initialization reported by coverity scan.
Signed-off-by: Michael Dawson mdawson@devrus.com