Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove usage of AllocatedBuffer from node_http2 #40584

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 24, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Oct 24, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@@ -323,7 +329,7 @@ void Http2Settings::Done(bool ack) {
double duration = (end - startTime_) / 1e6;

Local<Value> argv[] = {
ack ? v8::True(env()->isolate()) : v8::False(env()->isolate()),
ack ? True(env()->isolate()) : False(env()->isolate()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for these two in particular I tend to prefer keeping the v8:: prefix. Not blocking tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell is it because these are similar to true and false?

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2021
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions
Copy link
Contributor

Landed in ff536fa...f8035ec

@github-actions github-actions bot closed this Oct 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-node_http2 branch October 30, 2021 08:59
targos pushed a commit that referenced this pull request Nov 6, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40584
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants