src: remove usage of AllocatedBuffer from node_http2
#40584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
reviewed
Oct 24, 2021
| @@ -323,7 +329,7 @@ void Http2Settings::Done(bool ack) { | |||
| double duration = (end - startTime_) / 1e6; | |||
|
|
|||
| Local<Value> argv[] = { | |||
| ack ? v8::True(env()->isolate()) : v8::False(env()->isolate()), | |||
| ack ? True(env()->isolate()) : False(env()->isolate()), | |||
There was a problem hiding this comment.
nit: for these two in particular I tend to prefer keeping the v8:: prefix. Not blocking tho
There was a problem hiding this comment.
@jasnell is it because these are similar to true and false?
jasnell
approved these changes
Oct 24, 2021
24 tasks
addaleax
approved these changes
Oct 25, 2021
25 tasks
RaisinTen
added
the
author ready
This was referenced Oct 27, 2021
RaisinTen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in ff536fa...f8035ec |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 30, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen
deleted the
src/remove-usage-of-AllocatedBuffer-from-node_http2
branch
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com