Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for clakech #40589

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for clakech #40589

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 24, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 24, 2021
@Trott
Copy link
Member Author

Trott commented Oct 24, 2021

@clakech This uses a .mailmap entry to remove your users.noreply.github.com entry from AUTHORS and leave your axa.fr address. If you'd prefer we do it differently, please leave a comment. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 24, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@clakech
Copy link
Contributor

clakech commented Oct 24, 2021

👍

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2021
@github-actions
Copy link
Contributor

Landed in b88de12...a2d65c0

@github-actions github-actions bot closed this Oct 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 25, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for clakech
a2d65c0 
PR-URL: #40589
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott @targos
meta: consolidate AUTHORS entries for clakech
ec02e7b 
PR-URL: #40589
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entries for clakech
7b1c89f 
PR-URL: #40589
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@Trott Trott deleted the authors-cl branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Linkgoron Linkgoron Linkgoron approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @clakech @Linkgoron @VoltrexKeyva @nodejs-github-bot